Skip to content
This repository was archived by the owner on Mar 7, 2026. It is now read-only.

fix: modal be on the top#511

Merged
milaiwi merged 1 commit intoreorproject:mainfrom
weilirs:fix-overlap
Mar 26, 2025
Merged

fix: modal be on the top#511
milaiwi merged 1 commit intoreorproject:mainfrom
weilirs:fix-overlap

Conversation

@weilirs
Copy link
Copy Markdown
Collaborator

@weilirs weilirs commented Mar 26, 2025

fix
image

@weilirs weilirs requested a review from milaiwi March 26, 2025 14:04
Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed modal overlap issues by adjusting z-index values and improving modal component styling.

  • Added z-index: 9999 to modal container in /src/components/Common/Modal.tsx to ensure proper layering
  • Cleaned up whitespace in className string in /src/components/Settings/InitialSettingsSinglePage.tsx
  • Potential concern: Using a high fixed z-index (9999) could cause issues with future modal stacking/layering
  • Consider using a more maintainable z-index management system with CSS custom properties or a z-index scale

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@milaiwi
Copy link
Copy Markdown
Collaborator

milaiwi commented Mar 26, 2025

Looks good

@milaiwi milaiwi merged commit 365ce8c into reorproject:main Mar 26, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants